http: removing the old accessor for sendLocalReply#6931
Merged
alyssawilk merged 1 commit intoenvoyproxy:masterfrom May 14, 2019
Merged
http: removing the old accessor for sendLocalReply#6931alyssawilk merged 1 commit intoenvoyproxy:masterfrom
alyssawilk merged 1 commit intoenvoyproxy:masterfrom
Conversation
Contributor
Author
|
Review more about timing than anything else. My guess is per usual most folks won't move until we remove the old accessor but my guess may be wrong :-P |
mattklein123
approved these changes
May 14, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
I agree no one will do it until it's removed, but given this is a trivial fix I think it's fine to merge. Thanks for following through here!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes response code details (or at least an empty string) required.
This will require folks with downstream filters to alter their sendLocalReply if they have not already.
Risk Level: Low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Fixes #6542