mocks: Add MockClusterTypedMetadata and expose from MockClusterInfo.#6797
Conversation
|
@junr03 I think this replaces an earlier PR you were waiting on. |
|
/retest |
|
🔨 rebuilding |
junr03
left a comment
There was a problem hiding this comment.
@jeffpiazza-google can you refresh my memory about where we want to use this? It might make sense to also include in this PR a test that needs this. Otherwise, we are adding for completeness.
Let me know what you think
|
I have some Google-internal tests for which I was looking for something
like this, but I don't otherwise have any tests that exercise this.
/JEP
…On Mon, May 6, 2019 at 12:56 PM Jose Ulises Nino Rivera < ***@***.***> wrote:
***@***.**** commented on this pull request.
@jeffpiazza-google <https://github.com/jeffpiazza-google> can you refresh
my memory about where we want to use this? It might make sense to also
include in this PR a test that needs this. Otherwise, we are adding for
completeness.
Let me know what you think
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6797 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJ63CUVXPQ3CYYJQD2TTJT3PUBPNFANCNFSM4HKU3DOA>
.
|
junr03
left a comment
There was a problem hiding this comment.
makes sense to me. Thanks for the context. I'll pong to one of the googlers to review
|
@alyssawilk do you mind taking a quick look? |
alyssawilk
left a comment
There was a problem hiding this comment.
Looks good to me, but it's worth seeing if there's some upstream tests we can enhance. I've found internally-used code often gets cleaned up when folks notice it is "not being used" :-)
If you can't find anything just ping back and I'll merge and cross my finters :-)
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
I looked a bit, but didn't see any upstream tests that were natural consumers of these mocks. Nonetheless, we have some in-house tests for which we'd like to have these mocks available. |
Signed-off-by: Jeff Piazza <jeffpiazza@google.com>
0e11b10 to
2c88b5c
Compare
Signed-off-by: Jeff Piazza <jeffpiazza@google.com>
|
/retest |
|
🔨 rebuilding |
…k-typed-metadata Signed-off-by: Jeff Piazza <jeffpiazza@google.com>
Signed-off-by: Jeff Piazza jeffpiazza@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:Adds a MockClusterTypedMetadata class and exposes a default instance from MockClusterInfo.
Risk Level:Low
Testing:n/a
Docs Changes:n/a
Release Notes:n/a
[Optional Fixes #Issue]
[Optional Deprecated:]