quiche: Move a bunch of quic testonly platform libraries to //test.#6693
quiche: Move a bunch of quic testonly platform libraries to //test.#6693htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Bin Wu <wub@google.com>
|
/assign @danzh2010 |
|
/assign @jmarantz |
danzh2010
left a comment
There was a problem hiding this comment.
Just out of curiosity, why do we prefer small test-only libraries instead of one that bundles whatever needed for QUICHE e2e tests? quic_test.h, quic_expect_bug.h and quic_mock_log.h are needed for every test.
They are not needed by every test, but this is not important. My preference for small libraries comes from 1) It's what is done in internal quiche libraries, and 2) it's more flexible, it can express more complex dependency graphs compared to monolithic libraries. (Not saying I like complex dependency graphs:) |
|
/assign @htuch |
|
/assign @alyssawilk |
Description:
Move the following QUIC testonly platform libraries to //test:
Risk Level: none, only moved unused code.
Testing:
bazel test --test_output=all test/extensions/quic_listeners/quiche/platform:all @com_googlesource_quiche//:all
Docs Changes: none
Release Notes: none