Skip to content

build: initialize const vector explicitly#6604

Merged
htuch merged 1 commit intoenvoyproxy:masterfrom
lizan:fedora_fix
Apr 17, 2019
Merged

build: initialize const vector explicitly#6604
htuch merged 1 commit intoenvoyproxy:masterfrom
lizan:fedora_fix

Conversation

@lizan
Copy link
Copy Markdown
Member

@lizan lizan commented Apr 16, 2019

Signed-off-by: Lizan Zhou lizan@tetrate.io

Description:
Fixes #6584

Risk Level: Low
Testing: CI
Docs Changes:
Release Notes:

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan lizan requested a review from cmluciano April 16, 2019 20:05
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

@lizan
Copy link
Copy Markdown
Member Author

lizan commented Apr 16, 2019

@mattklein123 I'm not pretty sure why clang-8 is throwing error on this (and seems only on Fedora, see #6584), but it doesn't hurt to have this change.

@htuch htuch merged commit a87a09d into envoyproxy:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build: clang-8 failures on async_client_impl.cc

3 participants