examples: updating docker-compose version#6574
examples: updating docker-compose version#6574mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Chris Paika <paika.christopher@gmail.com>
0d7c64e to
fca3141
Compare
|
Not sure why the tests failed - seems like my changes are unrelated to the test files. Not sure if the main pipeline is broken, or the tests that failed are flaky? |
|
cc @moderation can you take a quick look? |
|
This looks fine to me and my local tests work. Looking at Circle CI output I think this is test flakes. /retest |
|
🔨 rebuilding |
|
@cpaika it would be nice to propagate this change to the rest of the examples docker-compose files. Extra points if while at it we rename all *.yml file to *.yaml for consistency throughout the repo AND update the 4 RST documentation files that refer to them. rg 'docker-compose.yml' docs/root/start/sandboxes/zipkin_tracing.rst docs/root/start/sandboxes/jaeger_tracing.rst docs/root/start/sandboxes/front_proxy.rst |
|
@moderation Thanks for giving me a next step to get into the codebase more! I was in the middlef of trying to see where I could get involved thats a perfect next baby step haha. I’ll get on it 👍 |
Description:
Upgrading the version of docker-compose for the front proxy example to be up to date with the latest (3.7). Not too many changes other than some feature adds, and removals of things that aren't being used in this docker-compose file. Docs for upgrading docker-compose from 2.x to 3.x
Risk Level: Low
Testing:
Manual testing, starting and hitting the example services after upgrading the version of docker-compose
Docs Changes:
N/A
Release Notes:
N/A