thread: Rename ThreadId::debugString to name#6548
Closed
mergeconflict wants to merge 1 commit intoenvoyproxy:masterfrom
mergeconflict:thread_id_name
Closed
thread: Rename ThreadId::debugString to name#6548mergeconflict wants to merge 1 commit intoenvoyproxy:masterfrom mergeconflict:thread_id_name
mergeconflict wants to merge 1 commit intoenvoyproxy:masterfrom
mergeconflict:thread_id_name
Conversation
Signed-off-by: Dan Rosen <mergeconflict@google.com>
Author
|
/review @htuch @sesmith177 |
htuch
approved these changes
Apr 10, 2019
Member
htuch
left a comment
There was a problem hiding this comment.
LGTM :) I'll wait to hear from others before merging.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Rename ThreadId::debugString to name, to avoid the possible misperception that it should be treated as unstable. This is to support #6517, which exposes thread IDs in stats.
Risk Level: low
Testing: existing tests
Docs Changes: n/a
Release Notes: n/a
Signed-off-by: Dan Rosen mergeconflict@google.com