docs: update load_balancing_weight behavior description#6467
Merged
snowp merged 1 commit intoenvoyproxy:masterfrom Apr 10, 2019
Merged
docs: update load_balancing_weight behavior description#6467snowp merged 1 commit intoenvoyproxy:masterfrom
snowp merged 1 commit intoenvoyproxy:masterfrom
Conversation
snowp
suggested changes
Apr 3, 2019
api/envoy/api/v2/eds.proto
Outdated
Contributor
There was a problem hiding this comment.
Maybe it makes more sense to explain locality selection first? I think it might help people understand the host selection model better
Contributor
Author
There was a problem hiding this comment.
Yeah I think that makes much more sense. Let me know how it looks now
Contributor
|
Mind merging master and fixing DCO? That should fix the coverage test |
Signed-off-by: John Howard <howardjohn@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: The documentation before was misleading; the weights are not actually multiplied together. This change brings the docs here in line with the actual behavior and the docs in other places
Risk Level: none
Testing: none
Docs Changes: this is only a docs change
Release Notes: n/a
Fixes #6458