test: remove v1 Redis HC tests#6367
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Mar 23, 2019
Merged
Conversation
Signed-off-by: Derek Argueta <dereka@pinterest.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This PR removes 2 tests that specifically exercise v1 API paths. This is under the observation that the cases being exercised are still tested through v2 API examples (
createRedisandcreateRedisWithoutKey) so there is no need to conduct v1->v2 translation for these tests. These tests simply existed to verify v1 compatibility but that is no longer a concern.The
parseHealthCheckFromV1Jsonfunction used for the v1 API tests cannot yet be deleted because it is used by v1 tests intest/common/upstream/health_checker_impl_test.cc. It'll be removed when that code is updated.Risk Level: Low (no functional change)
Testing:
Docs Changes: N/A
Release Notes: N/A
Resolves: a piece of #6362
Signed-off-by: Derek Argueta dereka@pinterest.com