Skip to content

test: convert HCM test configs to v2 YAML#6354

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
derekargueta:dereka/hcm-config-tests
Mar 22, 2019
Merged

test: convert HCM test configs to v2 YAML#6354
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
derekargueta:dereka/hcm-config-tests

Conversation

@derekargueta
Copy link
Copy Markdown
Member

Description: convert v1 JSON to v2 YAML for HttpConnectionManager unit tests
Risk Level: Low (no functional change)
Testing:
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Derek Argueta dereka@pinterest.com

Signed-off-by: Derek Argueta <dereka@pinterest.com>
Copy link
Copy Markdown
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@mattklein123 mattklein123 merged commit 7b1909b into envoyproxy:master Mar 22, 2019
@derekargueta derekargueta deleted the dereka/hcm-config-tests branch March 22, 2019 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants