http fault: implement header controlled faults#6318
Merged
mattklein123 merged 11 commits intomasterfrom Mar 26, 2019
Merged
Conversation
Part of #5942 Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
@rshriram do you mind taking a first pass? |
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
rshriram
reviewed
Mar 21, 2019
rshriram
reviewed
Mar 21, 2019
rshriram
reviewed
Mar 21, 2019
rshriram
reviewed
Mar 21, 2019
| header_delay: {} | ||
| percentage: | ||
| numerator: 100 | ||
| response_rate_limit: |
Member
There was a problem hiding this comment.
per previous discussion, i suggest cutting the percentage here and opting for a semantic like, "if you specify delay, it will be injected with 100% certainty". That would make it easier for people to test, imo
Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
@rshriram updated |
rshriram
reviewed
Mar 22, 2019
Signed-off-by: Matt Klein <mklein@lyft.com>
alyssawilk
reviewed
Mar 26, 2019
Contributor
alyssawilk
left a comment
There was a problem hiding this comment.
LGTM with a few minor nits
Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
@alyssawilk updated |
alyssawilk
reviewed
Mar 26, 2019
Member
Author
|
@alyssawilk updated, lmk if that is what you had in mind. |
alyssawilk
approved these changes
Mar 26, 2019
Contributor
alyssawilk
left a comment
There was a problem hiding this comment.
Fantastic - that's what I was hoping for!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5942
Risk Level: Low, does refactor some shared logic between filters, so not entirely
new feature only.
Testing: UTs and integration tests added.
Docs Changes: Added.
Release Notes: Added.