build: use tmpdir to build luajit#6202
Merged
lizan merged 1 commit intoenvoyproxy:masterfrom Mar 7, 2019
Merged
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
mattklein123
approved these changes
Mar 7, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
I tested locally, thanks for the quick fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lizan Zhou lizan@tetrate.io
Description:
Running make directly in LuaJIT source will break sandbox as the source directly is not writable. Copy it into current directly (which is tmpdir) to write into writable path.
Risk Level: Low
Testing: locally
Docs Changes:
Release Notes:
Fixes #6188.