Skip to content

test: switch hds_integration_test.cc real time while flakes with sim-time are sorted out.#6175

Merged
jmarantz merged 1 commit intoenvoyproxy:masterfrom
jmarantz:hds-integration-test-real-time
Mar 5, 2019
Merged

test: switch hds_integration_test.cc real time while flakes with sim-time are sorted out.#6175
jmarantz merged 1 commit intoenvoyproxy:masterfrom
jmarantz:hds-integration-test-real-time

Conversation

@jmarantz
Copy link
Copy Markdown
Contributor

@jmarantz jmarantz commented Mar 5, 2019

Description: Simulated time should make tests less flaky, but in this case simulated time appears to do the opposite.
Risk Level: low
Testing: test/integration:hds_integration_test --runs_per_test=1000
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz jmarantz requested a review from mattklein123 March 5, 2019 19:45
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@jmarantz jmarantz merged commit 0b702f0 into envoyproxy:master Mar 5, 2019
@jmarantz jmarantz deleted the hds-integration-test-real-time branch March 5, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants