decouple common/ssl from common/network#5386
Closed
bdecoste wants to merge 0 commit intoenvoyproxy:masterfrom
bdecoste:common_network
Closed
decouple common/ssl from common/network#5386bdecoste wants to merge 0 commit intoenvoyproxy:masterfrom bdecoste:common_network
bdecoste wants to merge 0 commit intoenvoyproxy:masterfrom
bdecoste:common_network
Conversation
Member
Contributor
Author
|
I inadvertently included some other changes so closed this and spend #5403. Sorry for the confusion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: As part of the work to support openssl this PR decouples the dependency of common/network on common/ssl. This is one step that will enable the linking and testing of openssl with a new transport socket for openssl. The common/network package did not require common/ssl so was straightforward to decouple.
Risk Level: Low
Testing: Standard tests passed
Docs Changes: None
Release Notes: None
[Optional Fixes #Issue]
[Optional Deprecated:]