Absl string view to std string in dynamic metadata#4078
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Aug 8, 2018
Merged
Absl string view to std string in dynamic metadata#4078mattklein123 merged 3 commits intoenvoyproxy:masterfrom
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Henna Huang <henna@google.com>
htuch
reviewed
Aug 7, 2018
|
|
||
| void DynamicMetadataImpl::setData(absl::string_view data_name, std::unique_ptr<Object>&& data) { | ||
| if (data_storage_.find(data_name) != data_storage_.end()) { | ||
| if (data_storage_.find(std::string(data_name)) != data_storage_.end()) { |
Member
There was a problem hiding this comment.
Please leave TODOs at each site to cleanup when we have full C++14 compliance.
Signed-off-by: Henna Huang <henna@google.com>
mattklein123
previously approved these changes
Aug 7, 2018
htuch
previously approved these changes
Aug 7, 2018
Contributor
Author
lizan
reviewed
Aug 7, 2018
| void DynamicMetadataImpl::setData(absl::string_view data_name, std::unique_ptr<Object>&& data) { | ||
| if (data_storage_.find(data_name) != data_storage_.end()) { | ||
| // TODO(Google): Remove string conversion when fixed internally. | ||
| if (data_storage_.find(std::string(data_name)) != data_storage_.end()) { |
Member
There was a problem hiding this comment.
this function does same conversion 5 lines below, have a variable to store it?
Signed-off-by: Henna Huang <henna@google.com>
mattklein123
approved these changes
Aug 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Henna Huang henna@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Convert absl string_view to std::string in the dynamic metadata library. This is needed for the Google import.
Risk Level: Low
Testing: Existing tests
Docs Changes: N/A
Release Notes: N/A
[Optional Fixes #Issue]
[Optional Deprecated:]