Skip to content

Remove dep to stats_impl#4057

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
dio:remove-stats-impl
Aug 5, 2018
Merged

Remove dep to stats_impl#4057
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
dio:remove-stats-impl

Conversation

@dio
Copy link
Copy Markdown
Member

@dio dio commented Aug 5, 2018

Description:
It seems stats_impl.* is removed since 1f11661

external/envoy/test/common/http/http2/codec_impl_fuzz_test.cc:14:10: fatal error: 'common/stats/stats_impl.h' file not found
#include "common/stats/stats_impl.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Risk Level: Low
Testing: Existing
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Dhi Aurrahman dio@tetrate.io

@dio
Remove stats_impl.h
7931229 
Since 1f11661

Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
@dio dio requested a review from htuch August 5, 2018 06:00
@kadajh
Copy link
Copy Markdown

kadajh commented Aug 5, 2018

Hi there,

After a long night of compiling the envoy code I have run into an issue where i can no longer build with the latest version of envoy.

My guess is that, when the code was revised either a file was missed or the file was not added during the merge.

I am going to scrub the repo to see if i can manually had another version of the file in the proper location. Maybe that will work.

Build Error:
test/common/http/http2/codec_impl_fuzz_test.cc:14:10: fatal error: 'common/stats/stats_impl.h' file not found
#include "common/stats/stats_impl.h"
^~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
INFO: Elapsed time: 52.688s, Critical Path: 12.11s
INFO: 34 processes: 34 darwin-sandbox.
FAILED: Build did NOT complete successfully
FAILED: Build did NOT complete successfully

mattklein123
mattklein123 approved these changes Aug 5, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. Hopefully the stats churn will be over soon.

@mattklein123 mattklein123 merged commit a1c6461 into envoyproxy:master Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

@htuch htuch Awaiting requested review from htuch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dio @kadajh @mattklein123