Skip to content

docs: fix incorrect doc about cluster warming in CDS#4040

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
ruoshan:doc/fix-cluster-warming-doc
Aug 7, 2018
Merged

docs: fix incorrect doc about cluster warming in CDS#4040
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
ruoshan:doc/fix-cluster-warming-doc

Conversation

@ruoshan
Copy link
Copy Markdown
Contributor

@ruoshan ruoshan commented Aug 3, 2018

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description: doc update
Risk Level: low
Testing:
Docs Changes: api/XDS_PROTOCOL.md
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

@ruoshan ruoshan force-pushed the doc/fix-cluster-warming-doc branch from 0c9cd38 to f04442d Compare August 3, 2018 02:03
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as you are in here do you mind fixing the "rotue" typo? Thank you!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe you forgot to push?

@ruoshan ruoshan force-pushed the doc/fix-cluster-warming-doc branch from f04442d to 0973440 Compare August 3, 2018 16:13
@ruoshan ruoshan force-pushed the doc/fix-cluster-warming-doc branch from 0973440 to c9d35e8 Compare August 7, 2018 01:32
Signed-off-by: Ruoshan Huang <ruoshan.huang@gmail.com>
@ruoshan
Copy link
Copy Markdown
Contributor Author

ruoshan commented Aug 7, 2018

Sorry for the trouble :( , fixed for real this time ;p

Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 82e3541 into envoyproxy:master Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants