Ability to specify a test or a test group when building with docker release#4030
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Aug 5, 2018
Merged
Conversation
… or test dir (e.g. //test/common/...) when building with docker release Signed-off-by: trabetti <talis@il.ibm.com>
mattklein123
reviewed
Aug 2, 2018
Member
mattklein123
left a comment
There was a problem hiding this comment.
Make sense to me. Thank you! Small nit.
| # Run only specified tests. | ||
| bazel --batch test ${BAZEL_TEST_OPTIONS} -c opt $2 | ||
| else | ||
| echo "Testing..." |
Member
There was a problem hiding this comment.
nit: indent got a bit messed up here.
Signed-off-by: trabetti <talis@il.ibm.com>
Signed-off-by: trabetti <talis@il.ibm.com>
mattklein123
reviewed
Aug 2, 2018
ci/do_ci.sh
Outdated
| bazel --batch test ${BAZEL_TEST_OPTIONS} -c opt //test/... | ||
|
|
||
| if [[ $# > 2 ]]; then | ||
| echo "Multiple tests are not supported, only $2 will run" |
Member
There was a problem hiding this comment.
nit: inconsistent indent. Also, couldn't we run more than 2 if we do some shifting of args and then wildcard arguments?
Contributor
Author
There was a problem hiding this comment.
Right, it is quite simple, did not think of it. Do you think this option should be added to other targets beside release?
Signed-off-by: trabetti <talis@il.ibm.com>
mattklein123
approved these changes
Aug 5, 2018
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, this is great. I would say let's just merge this and we can add to other targets later if people want them? (I can see dbg being useful also).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added ability to specify a test (e.g. //test/common/common:assert_test) or a test group (e.g. //test/common/...) when building with docker release
Signed-off-by: trabetti talis@il.ibm.com
Description: When compiling with Docker for development, I found it useful to compile and run only one test which I am currently working on, so I updated locally the do_ci.sh script to accommodate this option.
I thought I can suggest it as a PR, maybe it can be useful for someone else. If seems unnecessary, feel free to close...
example usage:
ENVOY_DOCKER_BUILD_DIR=~/envoy_fork/build-debug ./ci/run_envoy_docker.sh './ci/do_ci.sh bazel.release //test/common/stats:thread_local_store_test'
Risk Level: Low
Testing:
Docs Changes: ci/README.md
Release Notes: