Refactor TransportSocketFactoryContext and Cluster interfaces.#4026
Merged
mattklein123 merged 8 commits intoenvoyproxy:masterfrom Aug 2, 2018
Merged
Conversation
Signed-off-by: JimmyCYJ <jimmychen.0102@gmail.com>
Signed-off-by: JimmyCYJ <jimmychen.0102@gmail.com>
Signed-off-by: JimmyCYJ <jimmychen.0102@gmail.com>
Signed-off-by: JimmyCYJ <jimmychen.0102@gmail.com>
Signed-off-by: JimmyCYJ <jimmychen.0102@gmail.com>
Signed-off-by: JimmyCYJ <jimmychen.0102@gmail.com>
Member
Author
lizan
reviewed
Aug 1, 2018
| /** | ||
| * @return information about the local environment the server is running in. | ||
| */ | ||
| virtual const LocalInfo::LocalInfo& local_info() PURE; |
source/common/upstream/eds.h
Outdated
| const LocalInfo::LocalInfo& local_info, ClusterManager& cm, | ||
| Event::Dispatcher& dispatcher, Runtime::RandomGenerator& random, | ||
| bool added_via_api); | ||
| bool added_via_api, |
Member
There was a problem hiding this comment.
Can we keep added_via_api as the last parameter?
source/common/upstream/eds.h
Outdated
| bool added_via_api); | ||
| bool added_via_api, | ||
| Server::Configuration::TransportSocketFactoryContext& factory_context, | ||
| Stats::ScopePtr stats_scope); |
Member
There was a problem hiding this comment.
ScopePtr&&? (also for other ClusterImpl)
| Stats::IsolatedStoreImpl load_report_stats_store_; | ||
| mutable ClusterLoadReportStats load_report_stats_; | ||
| Network::TransportSocketFactoryPtr transport_socket_factory_; | ||
| Stats::ScopePtr stats_scope_; |
Signed-off-by: JimmyCYJ <jimmychen.0102@gmail.com>
Member
Author
|
@lizan Please take a look. Thanks! |
lizan
reviewed
Aug 2, 2018
| EXPECT_THROW(StaticClusterImpl(parseClusterFromJson(json), runtime, stats, ssl_context_manager, | ||
| local_info, cm, false), | ||
| EnvoyException); | ||
| EXPECT_THROW( |
Member
There was a problem hiding this comment.
Since you're already here, make this EXPECT_THROW_WITH_MESSAGE?
Member
Author
There was a problem hiding this comment.
Done. Please take a look.
Signed-off-by: JimmyCYJ <jimmychen.0102@gmail.com>
lizan
approved these changes
Aug 2, 2018
mattklein123
approved these changes
Aug 2, 2018
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, I like this cleanup. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor TransportSocketFactoryContext and Cluster interfaces.
Description:
According to #3700 , we introduce TransportSocketFactoryContextImpl that simplifies the interfaces of
ListenerImpl, ClusterImplBase and its derived classes. This PR implements TransportSocketFactoryContextImpl, and refactors ListenerImpl and Cluster interfaces. This PR is split out of #3700.
Risk Level: Low
Signed-off-by: Jimmy Chen jimmychen.0102@gmail.com