split up stats_impl_test to match the *impl.h and and *impl.cc files.#4024
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Aug 2, 2018
Merged
split up stats_impl_test to match the *impl.h and and *impl.cc files.#4024mattklein123 merged 3 commits intoenvoyproxy:masterfrom
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
reviewed
Aug 1, 2018
test/common/stats/BUILD
Outdated
| "//source/common/stats:stats_lib", | ||
| "//test/mocks/stats:stats_mocks", | ||
| "//source/common/stats:stats_options_lib", | ||
| # "//test/mocks/stats:stats_mocks", |
Member
There was a problem hiding this comment.
? (same elsewhere). Also, from a quick skim I think there are some commented out header includes in the source directory also. Can you take a look?
Contributor
Author
There was a problem hiding this comment.
Good catch -- sorry missed these on this BUILD file. Cleaned them up here & below.
I skimmed through this PR and also recursively grepped my workspace for "// #" and didn't see anything.
Member
There was a problem hiding this comment.
E.g. https://github.com/envoyproxy/envoy/blob/master/source/common/stats/histogram_impl.cc#L8 (not sure if there is anything else)
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
Ah my grep was wrong; fixed (4 new files in this PR now). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Marantz jmarantz@google.com
Description: This is the last of the stats implementation/test splitting. Still on queue: splitting the interface header.
Risk Level: low
Testing: //test/...
Docs Changes: N/A
Release Notes: N/A