Remove "DO NOT SUBMIT" comment.#4020
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom Aug 1, 2018
Merged
Conversation
It looks like this comment snuck in as part of PR 3936. It causes some hassles for Google import, since our internal presubmits are wary of code that contains comments with DO NOT SUBMIT in all caps. I think the original intent was to remove the comment before merging, and it should be safe to remove the comment given my review of the file. Signed-off-by: Dan Noé <dpn@google.com>
Contributor
Author
|
I believe master is currently broken for unrelated reasons, so I expect CI above to fail. I'll kick it again after that issue is fixed. @mkbehr FYI |
Contributor
|
Yeah, that comment is outdated. Thanks for catching it! |
ccaraman
approved these changes
Aug 1, 2018
Member
|
Can merge master now |
mattklein123
approved these changes
Aug 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
It looks like this comment snuck in as part of PR 3936. It causes some
hassles for Google import, since our internal presubmits are wary of
code that contains comments with DO NOT SUBMIT in all caps.
I think the original intent was to remove the comment before merging,
and it should be safe to remove the comment given my review of the
file.
Risk Level: Trivial
Testing: bazel test //test/...
Docs Changes: None
Release Notes: None
Signed-off-by: Dan Noé dpn@google.com