Skip to content

test: Fix perf_annotation_test compilation under gcc 8.1.1#4000

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
surki:gcc8_warn_fix
Aug 1, 2018
Merged

test: Fix perf_annotation_test compilation under gcc 8.1.1#4000
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
surki:gcc8_warn_fix

Conversation

@surki
Copy link
Copy Markdown
Contributor

@surki surki commented Jul 31, 2018

Signed-off-by: Suresh Kumar suresh@freshdesk.com

Description: Fixes "unnecessary parentheses" warning/error when compiled in gcc8.1.1
Risk Level: Low
Testing: bazel test //test/...
Docs Changes: N/A
Release Notes: N/A
Fixes #3680

@mattklein123
Copy link
Copy Markdown
Member

@surki apologies but can you fix DCO? See contributing guide.

@mattklein123 mattklein123 self-assigned this Jul 31, 2018
It fixes "unnecessary parentheses" warning/error when compiled in
gcc8.1.1

Signed-off-by: Suresh Kumar <suresh@freshdesk.com>
@surki
Copy link
Copy Markdown
Contributor Author

surki commented Aug 1, 2018

Updated.
ci mac check failure doesn't look related to this change?

@mattklein123 mattklein123 merged commit aeb3f28 into envoyproxy:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants