docs: minor typo and grammar fixups#3984
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Jul 30, 2018
Merged
Conversation
api/XDS_PROTOCOL.md
Outdated
Member
There was a problem hiding this comment.
As long as you are cleaning up grammar, this sentence still reads pretty confusingly to me. I think it would read better with what we had before, but in two sentences.
"For EDS/RDS, the management server does not need to supply every requested
resource and may also supply additional, unrequested resources. resource_names is only a hint." ? @htuch for thoughts also on this.
Minor fixups for the xDS protocol documentation. Signed-off-by: Nick Travers <n.e.travers@gmail.com>
702bc06 to
5d8b9b9
Compare
htuch
approved these changes
Jul 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor fixups for the xDS protocol documentation.
Signed-off-by: Nick Travers n.e.travers@gmail.com
Risk Level: Low
Docs Changes: Spelling and grammar in XDS_PROTOCOL.md