fuzz: fixes oss-fuzz: 9599, 9600#3979
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Jul 31, 2018
anirudhmurali:master
Merged
fuzz: fixes oss-fuzz: 9599, 9600#3979mattklein123 merged 2 commits intoenvoyproxy:masterfrom anirudhmurali:master
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
anirudhmurali:master
Conversation
Signed-off-by: Anirudh M <m.anirudh18@gmail.com>
htuch
reviewed
Jul 30, 2018
| // | ||
| // Priorities should range from 0 (highest) to N (lowest) without skipping. | ||
| uint32 priority = 5; | ||
| uint32 priority = 5 [(validate.rules).uint32 = {gte: 0, lte: 128}]; |
Member
There was a problem hiding this comment.
Thanks, this looks basically right. You don't need the gte: 0 though, since this is an unsigned int. @alyssawilk what do you think a sensible upper bound here is? Will 128 work? Seems reasonable to me.
Signed-off-by: Anirudh M <m.anirudh18@gmail.com>
htuch
approved these changes
Jul 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Fixes oss-fuzz: 9599, 9600
Description:
Both issues are due to
ERROR: libFuzzer: out-of-memorybecause of the usage of a large integer in the corpus. Added max constraint validate rule to the appropriate field.Risk Level: Low
Testing: Tested unit tests (
bazel test //test/server:server_fuzz_testandbazel test //test/server/config_validation:config_fuzz_test), built and ran fuzzers with oss-fuzz.Signed-off-by: Anirudh M m.anirudh18@gmail.com