Skip to content

test/mock: Add 3 new gmock matchers#3972

Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
jeffpiazza-google:misc-matchers
Jul 31, 2018
Merged

test/mock: Add 3 new gmock matchers#3972
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
jeffpiazza-google:misc-matchers

Conversation

@jeffpiazza-google
Copy link
Copy Markdown
Contributor

Description: Adds three new gmock matchers: Envoy::Http::HeaderHasValue, Envoy::Http::HeaderHasValueRef, and Envoy::Buffer::BufferStringContains.
Risk Level: Low
Testing: New test code only
Docs Changes: n/a
Release Notes: n/a

…sValueRef,

and Envoy::Buffer::BufferStringContains.

Signed-off-by: Jeff Piazza <jeffpiazza@google.com>
@mattklein123 mattklein123 self-assigned this Jul 30, 2018
@mattklein123
Copy link
Copy Markdown
Member

@jeffpiazza-google do you mind checking CI?

std::string where necessary.

Signed-off-by: Jeff Piazza <jeffpiazza@google.com>
Signed-off-by: Jeff Piazza <jeffpiazza@google.com>
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

@mattklein123 mattklein123 merged commit da3c1ea into envoyproxy:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants