syscall: refactor setSocketOption for better errno latching#3915
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Jul 28, 2018
Merged
syscall: refactor setSocketOption for better errno latching#3915mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
40204ed to
0ce8f7e
Compare
0ce8f7e to
556afec
Compare
This commit refactors setSocketOption to allow for returning the errno that is captured as soon as the syscall is performed. Signed-off-by: Venil Noronha <veniln@vmware.com>
556afec to
20a97ac
Compare
Member
Author
|
I've updated the routines to return the newly introduced |
mattklein123
approved these changes
Jul 28, 2018
Member
mattklein123
left a comment
There was a problem hiding this comment.
Awesome, this is great. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR refactors
setSocketOptionto allow for returning theerrnothat is captured as soon as the syscall is performed. See #3819 for more information.Signed-off-by: Venil Noronha veniln@vmware.com
Risk Level: Low
Testing: Existing tests suffice
Docs Changes: N/A
Release Notes: N/A