dynamic_modules: add filter state support for http filter#38979
Merged
mathetake merged 4 commits intoenvoyproxy:mainfrom Apr 7, 2025
Merged
dynamic_modules: add filter state support for http filter#38979mathetake merged 4 commits intoenvoyproxy:mainfrom
mathetake merged 4 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Zhaoyang Li <zhaoyli311@gmail.com>
Signed-off-by: Zhaoyang Li <zhaoyli311@gmail.com>
mathetake
reviewed
Apr 2, 2025
Member
There was a problem hiding this comment.
Thank you, overall looks good but high level comments:
- Does the string need to be limited to string? i can't find any rationale to restrict it to utf8 at Rust level, so I would expect it to be &[u8] instead of &str. And change the suffix in the ABI to "bytes" instead of string.
- Could you use the new API in http.rs, and add a test in filter_test.cc accordingly?
/wait
mathetake
reviewed
Apr 2, 2025
11 tasks
Signed-off-by: Zhaoyang Li <zhaoyli311@gmail.com>
Signed-off-by: Zhaoyang Li <zhaoyli311@gmail.com>
mathetake
approved these changes
Apr 7, 2025
| } | ||
|
|
||
| TEST(DynamiModulesTest, DynamicMetadataCallbacks) { | ||
| TEST(DynamicModulesTest, DynamicMetadataCallbacks) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: add filter state support for dynamic modules http filter
Additional Description: With filter state support, dynamic modules rust filter can get filter state from envoy
Risk Level: low
Testing: unit test
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A