mobile: Force mobile-release-common build to use C++17#33047
Merged
abeyad merged 1 commit intoenvoyproxy:mainfrom Mar 21, 2024
Merged
mobile: Force mobile-release-common build to use C++17#33047abeyad merged 1 commit intoenvoyproxy:mainfrom
abeyad merged 1 commit intoenvoyproxy:mainfrom
Conversation
It was defaulting to C++20 due to envoyproxy#32585, but for mobile, we are still on C++17. This change enables local builds to build with C++17 without encountering toolchain errors. Signed-off-by: Ali Beyad <abeyad@google.com>
phlax
approved these changes
Mar 21, 2024
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was defaulting to C++20 due to
#32585, but for mobile, we are still on C++17. This change enables local builds to build with C++17 without encountering toolchain errors.