Skip to content

Revert "Support api config source without cluster names (#3030)"#3063

Merged
mattklein123 merged 1 commit intomasterfrom
revert_config_source_change
Apr 12, 2018
Merged

Revert "Support api config source without cluster names (#3030)"#3063
mattklein123 merged 1 commit intomasterfrom
revert_config_source_change

Conversation

@mattklein123
Copy link
Copy Markdown
Member

This reverts commit b8e2eee.

Signed-off-by: Matt Klein mklein@lyft.com

This reverts commit b8e2eee.

Signed-off-by: Matt Klein <mklein@lyft.com>
@mattklein123
Copy link
Copy Markdown
Member Author

@ambuc @htuch unfortunately I think we are going to need a take 3 on this. Sorry. :( I think @htuch already knows what the problem is.

#9 google::protobuf::internal::LogMessage::Finish() at common.cc:269
  #10 google::protobuf::internal::LogFinisher::operator=(google::protobuf::internal::LogMessage&) at common.cc:277
  #11 google::protobuf::RepeatedPtrField<envoy::api::v2::core::GrpcService>::TypeHandler::Type const& google::protobuf::internal::RepeatedPtrFieldBase::Get<google::protobuf::RepeatedPtrField<envoy::api::v2::core::GrpcService>::TypeHandler>(int) const at repeated_field.h:1522
  #12 google::protobuf::RepeatedPtrField<envoy::api::v2::core::GrpcService>::Get(int) const at repeated_field.h:1989
  #13 envoy::api::v2::core::ApiConfigSource::grpc_services(int) const at config_source.pb.h:621
  #14 Envoy::Config::Utility::factoryForGrpcApiConfigSource(Envoy::Grpc::AsyncClientManager&, envoy::api::v2::core::ApiConfigSource const&, Envoy::Stats::Scope&) at utility.cc:221
  #15 std::unique_ptr<Envoy::Config::Subscription<envoy::api::v2::Cluster>, std::default_delete<Envoy::Config::Subscription<envoy::api::v2::Cluster> > > Envoy::Config::SubscriptionFactory::subscriptionFromConfigSource<envoy::api::v2::Cluster>(envoy::api::v2::core::ConfigSource const&, envoy::api::v2::core::Node const&, Envoy::Event::Dispatcher&, Envoy::Upstream::ClusterManager&, Envoy::Runtime::RandomGenerator&, Envoy::Stats::Scope&, std::function<Envoy::Config::Subscription<envoy::api::v2::Cluster>* ()>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) at subscription_factory.h:68
  #16 CdsApiImpl at cds_api_impl.cc:36
  #17 Envoy::Upstream::CdsApiImpl::create(envoy::api::v2::core::ConfigSource const&, absl::optional<envoy::api::v2::core::ConfigSource> const&, Envoy::Upstream::ClusterManager&, Envoy::Event::Dispatcher&, Envoy::Runtime::RandomGenerator&, Envoy::LocalInfo::LocalInfo const&, Envoy::Stats::Scope&) at cds_api_impl.cc:24
  #18 Envoy::Upstream::ProdClusterManagerFactory::createCds(envoy::api::v2::core::ConfigSource const&, absl::optional<envoy::api::v2::core::ConfigSource> const&, Envoy::Upstream::ClusterManager&) at cluster_manager_impl.cc:898
  #19 Envoy::Upstream::ValidationClusterManagerFactory::createCds(envoy::api::v2::core::ConfigSource const&, absl::optional<envoy::api::v2::core::ConfigSource> const&, Envoy::Upstream::ClusterManager&) at cluster_manager.cc:27
  #20 ClusterManagerImpl at cluster_manager_impl.cc:273
  #21 ValidationClusterManager at cluster_manager.cc:37
  #22 Envoy::Upstream::ValidationClusterManagerFactory::clusterManagerFromProto(envoy::config::bootstrap::v2::Bootstrap const&, Envoy::Stats::Store&, Envoy::ThreadLocal::Instance&, Envoy::Runtime::Loader&, Envoy::Runtime::RandomGenerator&, Envoy::LocalInfo::LocalInfo const&, Envoy::AccessLog::AccessLogManager&) at cluster_manager.cc:18
  #23 Envoy::Server::Configuration::MainImpl::initialize(envoy::config::bootstrap::v2::Bootstrap const&, Envoy::Server::Instance&, Envoy::Upstream::ClusterManagerFactory&) at configuration_impl.cc:48
  #24 ConfigTest at config_test.cc:70
  #25 Envoy::ConfigTest::run(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) at config_test.cc:114
  #26 Envoy::LyftConfigTest_All_Test::TestBody() at lyft_config_test.cc:26
  #27 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) at gtest.cc:2457
  #28 testing::Test::Run() at gtest.cc:2473
  #29 testing::TestInfo::Run() at gtest.cc:2655
  #30 testing::TestCase::Run() at gtest.cc:2773
  #31 testing::internal::UnitTestImpl::RunAllTests() at gtest.cc:4673
  #32 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) at gtest.cc:2457
  #33 testing::UnitTest::Run() at gtest.cc:4281
  #34 RUN_ALL_TESTS() at gtest.h:2237
  #35 Envoy::TestRunner::RunTests(int, char**) at test_runner.h:34
  #36 main at main.cc:35
terminate called after throwing an instance of 'google::protobuf::FatalException'
  what():  CHECK failed: (index) < (current_size_): 

https://github.com/envoyproxy/envoy/blob/master/source/common/config/utility.cc#L221

@mattklein123 mattklein123 merged commit 8b4c2d6 into master Apr 12, 2018
@mattklein123 mattklein123 deleted the revert_config_source_change branch April 12, 2018 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants