Skip to content

deps: Bump actions/checkout -> v3 (dependabot + fixes)#25506

Merged
phlax merged 9 commits intoenvoyproxy:mainfrom
phlax:gh-actions-checkout
Feb 13, 2023
Merged

deps: Bump actions/checkout -> v3 (dependabot + fixes)#25506
phlax merged 9 commits intoenvoyproxy:mainfrom
phlax:gh-actions-checkout

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Feb 13, 2023

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@dependabot @phlax
build(deps): bump actions/checkout from 1 to 3
211671d 
Bumps [actions/checkout](https://github.com/actions/checkout) from 1 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v1...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title deps: Bump actions/checkout -> v3 (dependabot + fixes) [WIP] deps: Bump actions/checkout -> v3 (dependabot + fixes) Feb 13, 2023
@phlax phlax marked this pull request as draft February 13, 2023 08:48
@phlax phlax force-pushed the gh-actions-checkout branch from 372210d to eebdccd Compare February 13, 2023 08:54
@phlax phlax changed the title [WIP] deps: Bump actions/checkout -> v3 (dependabot + fixes) deps: Bump actions/checkout -> v3 (dependabot + fixes) Feb 13, 2023
@phlax phlax marked this pull request as ready for review February 13, 2023 08:54
@phlax phlax force-pushed the gh-actions-checkout branch from eebdccd to 01a00c4 Compare February 13, 2023 08:55
@phlax
set-checkout-depth
d6dc1ae 
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the gh-actions-checkout branch from 01a00c4 to d6dc1ae Compare February 13, 2023 08:59
@phlax phlax mentioned this pull request Feb 13, 2023
Closed
@jpsim
Copy link
Copy Markdown
Contributor

jpsim commented Feb 13, 2023

Odd that the android_build and child jobs never started?

image

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Feb 13, 2023

/retest

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Feb 13, 2023

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.

🐱

Caused by: a #25506 (comment) was created by @phlax.

see: more, trace.

@jpsim
Copy link
Copy Markdown
Contributor

jpsim commented Feb 13, 2023

Actually it looks like there's a mistake in the yaml configs:

Invalid workflow file: .github/workflows/ios_build.yml#L21
The workflow is not valid. .github/workflows/ios_build.yml (Line: 21, Col: 7): Unexpected value 'fetch-depth' .github/workflows/ios_build.yml (Line: 47, Col: 7): Unexpected value 'fetch-depth'

image

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Feb 13, 2023

could be me force pushing - i can look further if its blocking it somehow

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Feb 13, 2023

Actually it looks like there's a mistake in the yaml configs:

ah that would explain it - let me update ...

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Feb 13, 2023

hmm - wierd - im not seeing the error - its seems correct https://github.com/actions/checkout#usage and is working everywhere else

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Feb 13, 2023

merged main altho dont see any reason it would merge badly - lets see

@jpsim
Copy link
Copy Markdown
Contributor

jpsim commented Feb 13, 2023

It seems to only be happening on macOS, the Linux jobs are running fine.

Invalid workflow file: .github/workflows/android_build.yml#L21
The workflow is not valid. .github/workflows/android_build.yml (Line: 21, Col: 7): Unexpected value 'fetch-depth' .github/workflows/android_build.yml (Line: 53, Col: 7): Unexpected value 'fetch-depth'

https://github.com/envoyproxy/envoy/actions/runs/4164747882

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Feb 13, 2023

nm - i think it needs a with not sure why it does/not work - but ill update with correct syntax ...

phlax added 2 commits February 13, 2023 15:08
@phlax
fix-action-with
65beb6b 
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
more-with-fixes
0c9762e 
Signed-off-by: Ryan Northey <ryan@synca.io>
@jpsim
Copy link
Copy Markdown
Contributor

jpsim commented Feb 13, 2023

I see this is now done automatically:

Adding repository directory to the temporary git global config as a safe directory
/usr/local/bin/git config --global --add safe.directory /Users/runner/work/envoy/envoy

So can we remove the explicit steps that do that in our workflow configs?

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Feb 13, 2023

So can we remove the explicit steps that do that in our workflow configs?

yep - i was intending to follow up with that

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Feb 13, 2023

@jpsim would you prefer if i just added that here ?

@jpsim
Copy link
Copy Markdown
Contributor

jpsim commented Feb 13, 2023

Yes can you please do that here? The time to cut that out should be offset by not having the overhead of creating/reviewing/waiting for CI on a new PR.

@phlax
safe-dir
bad1202 
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Feb 13, 2023

i rem now why i didnt include - when i tried this before it failed - it has some perms issue and i dont see obvious way to resolve

can we just revert this and land the action update ?

@jpsim
Copy link
Copy Markdown
Contributor

jpsim commented Feb 13, 2023

can we just revert this and land the action update ?

Yes of course.

@phlax
no-safe-dir
c233929 
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Feb 13, 2023

So can we remove the explicit steps that do that in our workflow configs?

reread your comment and the docs better and realized we can just remove - so hopefully that works - apologies for noise

phlax added 2 commits February 13, 2023 15:49
@phlax
Revert "no-safe-dir"
79ed451 
This reverts commit c233929.

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Revert "safe-dir"
bd18f51 
This reverts commit bad1202.

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Feb 13, 2023

argh - that still failed - reverted!

@phlax phlax enabled auto-merge (squash) February 13, 2023 16:28
@phlax phlax merged commit 336d06b into envoyproxy:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jpsim jpsim jpsim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jpsim jpsim

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phlax @jpsim