Skip to content

grpc access log: fix crash when downstream addresses not set#2530

Merged
mattklein123 merged 1 commit intomasterfrom
fix_grpc_access_log_crash
Feb 5, 2018
Merged

grpc access log: fix crash when downstream addresses not set#2530
mattklein123 merged 1 commit intomasterfrom
fix_grpc_access_log_crash

Conversation

@mattklein123
Copy link
Copy Markdown
Member

Risk Level: Low
Testing: Unit
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Matt Klein <mklein@lyft.com>
@htuch
Copy link
Copy Markdown
Member

htuch commented Feb 5, 2018

Looks like metrics_service_integration_test hung in TSAN; I've triggered a relaunch of this. We should keep an eye out for this one, I've added to my TODO to try and see if I can replicate a flake when there is some spare time.

@mattklein123 mattklein123 merged commit 0f88bc5 into master Feb 5, 2018
@mattklein123 mattklein123 deleted the fix_grpc_access_log_crash branch February 5, 2018 05:18
@alyssawilk
Copy link
Copy Markdown
Contributor

#2532 filed. @htuch next time you see it, could you note where it hung on the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants