Use a named struct instead of a pair in key_value_store_base.h#23904
Merged
RyanTheOptimist merged 3 commits intoenvoyproxy:mainfrom Nov 9, 2022
Merged
Use a named struct instead of a pair in key_value_store_base.h#23904RyanTheOptimist merged 3 commits intoenvoyproxy:mainfrom
RyanTheOptimist merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Ryan Hamilton <rch@google.com>
Contributor
Author
|
/assign @alyssawilk |
alyssawilk
previously approved these changes
Nov 8, 2022
Signed-off-by: Ryan Hamilton <rch@google.com>
alyssawilk
approved these changes
Nov 9, 2022
Contributor
alyssawilk
left a comment
There was a problem hiding this comment.
hah! I was surprised it didn't require test updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::pair tends to result in fairly unreadable code so use a named struct instead.
Also make members private instead of public as per the style guide.
Signed-off-by: Ryan Hamilton rch@google.com
Risk Level: Low
Testing: Existing tests
Docs Changes: N/A
Release Notes: N/A