Merged
Conversation
Both things the comment says are inaccurate: After envoyproxy#23320, this mechanism no longer uses the X509_STORE callback, but a flag. After envoyproxy#21417, Envoy is also not (always) using SSL_CTX_set_cert_verify_callback, but a different one. Just remove the comment altogether, as it doesn't seem to provide any value. All it's saying is that, because Envoy still uses `store` at the end of the day, configuring things on `store` does stuff. But the whole function configures things on `store`, so it's not specific to that block anyway. Signed-off-by: David Benjamin <davidben@google.com>
Contributor
|
/assign @lizan |
lizan
approved these changes
Nov 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Both things the comment says are inaccurate: After #23320, this mechanism no longer uses the X509_STORE callback, but a flag. After #21417, Envoy is also not (always) using
SSL_CTX_set_cert_verify_callback, but a different one.
Just remove the comment altogether, as it doesn't seem to provide any value. All it's saying is that, because Envoy still uses
storeat the end of the day, configuring things onstoredoes stuff. But the whole function configures things onstore, so it's not specific to that block anyway.Signed-off-by: David Benjamin davidben@google.com
Additional Description:
Risk Level: none (comment-only change)
Testing: CI (comment-only change)
Docs Changes: n/a (comment-only change)
Release Notes: n/a (comment-only change)
Platform Specific Features: n/a (comment-only change)
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]