Rename H/1 codec method to reduce confusion#22408
Merged
alyssawilk merged 2 commits intoenvoyproxy:mainfrom Aug 1, 2022
Merged
Rename H/1 codec method to reduce confusion#22408alyssawilk merged 2 commits intoenvoyproxy:mainfrom
alyssawilk merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Yan Avlasov <yavlasov@google.com>
alyssawilk
reviewed
Jul 26, 2022
Contributor
alyssawilk
left a comment
There was a problem hiding this comment.
Now that I think about it, do you think completeCurrentHeader would be less confusing?
completeLast also reads as the last header, not the last one to be parsed.
/wait
Signed-off-by: Yan Avlasov <yavlasov@google.com>
Contributor
Author
|
done |
alyssawilk
approved these changes
Aug 1, 2022
Contributor
alyssawilk
left a comment
There was a problem hiding this comment.
thanks for the clean up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: Low
Testing: Unit Tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Signed-off-by: Yan Avlasov yavlasov@google.com