Skip to content

uhv: disable oghttp2 header validation when uhv is enabled#22078

Merged
yanavlasov merged 4 commits intoenvoyproxy:mainfrom
trail-of-forks:h2-uhv-complier-flag
Aug 15, 2022
Merged

uhv: disable oghttp2 header validation when uhv is enabled#22078
yanavlasov merged 4 commits intoenvoyproxy:mainfrom
trail-of-forks:h2-uhv-complier-flag

Conversation

@ameily
Copy link
Copy Markdown
Contributor

@ameily ameily commented Jul 8, 2022

Commit Message: uhv: disable oghttp2 header validation when uhv is enabled
Additional Description: Disable header validation within oghttp2 when the UHV compiler flag is enabled
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
Fixes: #21548
Fixes: #19751

@ameily
Copy link
Copy Markdown
Contributor Author

ameily commented Jul 9, 2022

CC @yanavlasov

@adisuissa
Copy link
Copy Markdown
Contributor

/assign @yanavlasov

@phlax
Copy link
Copy Markdown
Member

phlax commented Jul 20, 2022

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #22078 (comment) was created by @phlax.

see: more, trace.

@phlax
Copy link
Copy Markdown
Member

phlax commented Jul 20, 2022

@ameily i think this probably needs a main merge - lets see...

yep - it does

/wait

@phlax
Copy link
Copy Markdown
Member

phlax commented Jul 20, 2022

/wait

ameily added 2 commits July 21, 2022 05:00
Signed-off-by: Adam Meily <adam.meily@trailofbits.com>
Signed-off-by: Adam Meily <adam.meily@trailofbits.com>
@ameily ameily force-pushed the h2-uhv-complier-flag branch from 22ca61d to 02459dc Compare July 21, 2022 09:18
@ameily
Copy link
Copy Markdown
Contributor Author

ameily commented Jul 21, 2022

@phlax I rebased on main. CI is failing a couple steps that I think just need to be run again.

  • linux coverage: //test/integration:tcp_tunneling_integration_test fails, but passes locally for me
  • windows: failed to download bazel

@phlax
Copy link
Copy Markdown
Member

phlax commented Jul 21, 2022

yep, looks like flakes - ill follow up on the first one - i think ive seen it elsewhere

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #22078 (comment) was created by @phlax.

see: more, trace.

@alyssawilk alyssawilk self-assigned this Aug 1, 2022
Copy link
Copy Markdown
Contributor

@yanavlasov yanavlasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/wait

Signed-off-by: Adam Meily <adam.meily@trailofbits.com>
Signed-off-by: Adam Meily <adam.meily@trailofbits.com>
@yanavlasov yanavlasov merged commit 10d9e9f into envoyproxy:main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

uhv: oghttp2: disable header validations based on compile flag uhv: nghttp2 patch: add option to disable header validation

5 participants