socket: add get sockopt for connect#17729
Merged
zuercher merged 7 commits intoenvoyproxy:mainfrom Sep 2, 2021
Merged
Conversation
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
antoniovicente
previously approved these changes
Aug 26, 2021
Contributor
antoniovicente
left a comment
There was a problem hiding this comment.
Change looks good. Sorry for the delay, I have been relatively busy ramping up on my new role.
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
antoniovicente
previously approved these changes
Sep 1, 2021
Contributor
|
/assign-from @envoyproxy/senior-maintainers |
|
@envoyproxy/senior-maintainers assignee is @zuercher |
zuercher
reviewed
Sep 1, 2021
Member
zuercher
left a comment
There was a problem hiding this comment.
Looks good. I have one suggestion for a log message that was confusing to me.
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Contributor
Author
Fixed. could you take another look? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Client connection can be created with least changes using underlying user space io socket per comment #16763 (comment)
Signed-off-by: Yuchen Dai silentdai@gmail.com
Additional Description:
Add a new constructor at ClientConnectionImpl to create an envoy's client connection using the user space io socket.
Add the getSocketOption used by connect().
The added test case verifies that client connection can be established and closed.
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]