[release/v1.18] jwt_authn: implementation of www-authenticate header (#16216)#17426
Merged
lizan merged 1 commit intoenvoyproxy:release/v1.18from Jul 28, 2021
Merged
Conversation
97fdcbd to
4d84c3a
Compare
Signed-off-by: Ryan Sutton <ryan.sutton@volunteers.acasi.info> Co-authored-by: Lizan Zhou <lizan@tetrate.io> Signed-off-by: cyran-ryan <58446431+cyran-ryan@users.noreply.github.com>
4d84c3a to
8c23f80
Compare
Contributor
|
This lgtm, although I noticed that changes to test/common/tracing/http_tracer_impl_test.cc present in the original PR are not here. I don't think |
dmitri-d
approved these changes
Jul 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Cherry-pick of 9fee580 of "jwt_authn: implementation of www-authenticate header (#16216)" to release 1.18
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]