Fix the bug that validate flag is not set when the SAN(SubjectAltName) matching is performed#16816
Merged
yanavlasov merged 11 commits intoenvoyproxy:mainfrom Jun 22, 2021
Merged
Fix the bug that validate flag is not set when the SAN(SubjectAltName) matching is performed#16816yanavlasov merged 11 commits intoenvoyproxy:mainfrom
validate flag is not set when the SAN(SubjectAltName) matching is performed#16816yanavlasov merged 11 commits intoenvoyproxy:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When SAN(SubjectAltName) matching with the provided matchers is the only verification performed and matching succeeds, the
validatedflag is not updated properly(i.e. left asNotValidated) and the function return wrong status code.Add the unit test:
DefaultValidatorobject with NULL certificateValidationContext (i.e no validation context). This ensures that the certificate verification later will be only performed on the SAN matcher arg provided in step#3Risk Level: Low
Testing:
Docs Changes: n/a
Release Notes: n/a
Signed-off-by: Tianyu Xia tyxia@google.com