Skip to content

python: Integrate linting#15886

Merged
htuch merged 5 commits intoenvoyproxy:mainfrom
phlax:py-move-configs
Apr 8, 2021
Merged

python: Integrate linting#15886
htuch merged 5 commits intoenvoyproxy:mainfrom
phlax:py-move-configs

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Apr 8, 2021

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: python: Integrate linting
Additional Description:

  • moves all tooling configs to repo root to allow using them directly and make explicit
  • moves the python linting job to format_pre only and includes a diff there

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

phlax added 5 commits April 8, 2021 16:24
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
This reverts commit 0e1cdfdd98fd0ff31b0e2eec76b900fadaeca13e.

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the py-move-configs branch from bbba7ea to 77b68ca Compare April 8, 2021 15:24
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Apr 8, 2021

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #15886 (comment) was created by @phlax.

see: more, trace.

Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit acc78e6 into envoyproxy:main Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants