http3: turning up upstream integration test#15841
Merged
alyssawilk merged 4 commits intoenvoyproxy:mainfrom Apr 6, 2021
Merged
http3: turning up upstream integration test#15841alyssawilk merged 4 commits intoenvoyproxy:mainfrom
alyssawilk merged 4 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
commented
Apr 6, 2021
| @@ -110,8 +110,6 @@ void EnvoyQuicClientStream::resetStream(Http::StreamResetReason reason) { | |||
| } | |||
|
|
|||
| void EnvoyQuicClientStream::switchStreamBlockState(bool should_block) { | |||
Contributor
Author
There was a problem hiding this comment.
This assert was basically "we should not be flow control blocked before reading body data" which turns out not to be true once you have multiple streams on one connection.
|
|
||
| void EnvoyQuicClientStream::maybeDecodeTrailers() { | ||
| if (sequencer()->IsClosed() && !FinishedReadingTrailers()) { | ||
| ASSERT(!received_trailers().empty()); |
Contributor
Author
There was a problem hiding this comment.
turns out it's fine to have empty trailers if the peer sends empty trailers :-P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turning up http2 upstream tests for http3.
Risk Level: n/a (test only)
Testing: yes
Docs Changes: n/a
Release Notes: n/a
Part of #15649