ext_proc: Refactor state processing#15828
Merged
htuch merged 1 commit intoenvoyproxy:mainfrom Apr 5, 2021
Merged
Conversation
Commit message: Reorganize some of the logic from the core filter into a set of classes. This eliminates some duplicate logic, and it also will make it easier to implement some up coming features without so much code duplication. Risk Level: Low Testing: Existing unit and integration tests Signed-off-by: Gregory Brail <gregbrail@google.com>
htuch
reviewed
Apr 5, 2021
| hdrs = ["ext_proc.h"], | ||
| srcs = [ | ||
| "ext_proc.cc", | ||
| "processor_state.cc", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message: Reorganize some of the logic from the core filter into a set of
classes. This eliminates some duplicate logic, and it also
will make it easier to implement some up coming features without
so much code duplication.
Risk Level: Low
Testing: Existing unit and integration tests
Signed-off-by: Gregory Brail gregbrail@google.com