Windows: Add note regarding the usage of ./ci/run_envoy_docker#15820
Merged
mattklein123 merged 2 commits intoenvoyproxy:mainfrom Apr 8, 2021
Merged
Windows: Add note regarding the usage of ./ci/run_envoy_docker#15820mattklein123 merged 2 commits intoenvoyproxy:mainfrom
./ci/run_envoy_docker#15820mattklein123 merged 2 commits intoenvoyproxy:mainfrom
Conversation
…sh './ci/windows_ci_steps.sh' Signed-off-by: davinci26 <sotirisnan@gmail.com>
Signed-off-by: davinci26 <sotirisnan@gmail.com>
Member
Author
|
@wrowe as discussed offline cc @envoyproxy/windows-dev |
Member
|
Probably also worth eventually emulating the Linux helper script pattern or maybe even merging the two |
Member
Author
|
We already have #15819 |
wrowe
approved these changes
Apr 2, 2021
Contributor
wrowe
left a comment
There was a problem hiding this comment.
LGTM, thanks for creating an issue for follow-up.
Member
Author
|
@envoyproxy/senior-maintainers can someone merge this small doc change? |
mattklein123
approved these changes
Apr 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sotiris Nanopoulos <sonanopo@,microsoft.com>
Windows Build: Add note regarding the usage of
./ci/run_envoy_docker.sh './ci/windows_ci_steps.sh'