techdebt: clean up connection_handler_impl dependency issue#15815
Merged
ggreenway merged 6 commits intoenvoyproxy:mainfrom Apr 7, 2021
Merged
techdebt: clean up connection_handler_impl dependency issue#15815ggreenway merged 6 commits intoenvoyproxy:mainfrom
ggreenway merged 6 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
lambdai
commented
Apr 1, 2021
| } | ||
| } // namespace | ||
|
|
||
| void ActiveTcpListener::removeConnection(ActiveTcpConnection& connection) { |
Contributor
Author
There was a problem hiding this comment.
This functions is moved to bottom and constructor is now on the top
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
ggreenway
approved these changes
Apr 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Follow up of #15553.
The last part of source/ directory.
Signed-off-by: Yuchen Dai silentdai@gmail.com
Additional Description:
Will rewrite test code fix flaky tests.
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
Fixes #15126