quiche: Fix crash in Quic listener upon request without authority#15799
Merged
mattklein123 merged 2 commits intoenvoyproxy:mainfrom Apr 2, 2021
Merged
quiche: Fix crash in Quic listener upon request without authority#15799mattklein123 merged 2 commits intoenvoyproxy:mainfrom
mattklein123 merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Dan Zhang <danzh@google.com>
Contributor
|
I think this is related to testing with https://github.com/kazu-yamamoto/h3spec/ |
alyssawilk
reviewed
Apr 1, 2021
| std::unique_ptr<Http::RequestHeaderMapImpl> headers = | ||
| quicHeadersToEnvoyHeaders<Http::RequestHeaderMapImpl>(header_list); | ||
| if (!Http::HeaderUtility::authorityIsValid(headers->Host()->value().getStringView())) { | ||
| if (Http::HeaderUtility::requestHeadersValid(*headers) != absl::nullopt) { |
Contributor
There was a problem hiding this comment.
Nice!
Want to set details here or wait and add them all at once?
Contributor
Author
There was a problem hiding this comment.
I will set invalid http header response code in #15753
Signed-off-by: Dan Zhang <danzh@google.com>
alyssawilk
approved these changes
Apr 1, 2021
Contributor
Author
|
/assign @mattklein123 |
Contributor
|
@danzh2010 @alyssawilk I can confirm the fix works with no crashes using h3spec 0.1.6. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Zhang danzh@google.com
Commit Message: Fix a recent regression where Quic listener crash while decoding request headers without
:authorityfield.Risk Level: low, WIP feature.
Testing: added integration test