docs: Add sequence diagram for xDS error_detail NACK example#15795
Merged
htuch merged 6 commits intoenvoyproxy:mainfrom Apr 2, 2021
Merged
docs: Add sequence diagram for xDS error_detail NACK example#15795htuch merged 6 commits intoenvoyproxy:mainfrom
htuch merged 6 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
htuch
reviewed
Apr 2, 2021
| S->C: {resources={A}, version=1, nonce=1} | ||
| C->S: {resource_names={A}, version=1, nonce=1 (this is an ACK)} | ||
| C->S: {resource_names={A, B}, version=1, nonce=1} | ||
| Note over C: adding subscription\nto B |
Member
There was a problem hiding this comment.
I think in all the "Note over"s that they are below the line they are referring to. E.g. here, the addition of subscription to B by the client happens in the line above when {A, B} is sent.
Contributor
Author
There was a problem hiding this comment.
Rearranged these to be clearer now.
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: eric846 56563761+eric846@users.noreply.github.com
Commit Message: docs: Add sequence diagram for xDS error_detail NACK example
Additional Description: n/a
Risk Level: Low: doc formatting
Testing: n/a
Docs Changes: converted text to a diagram
Release Notes: n/a
Platform Specific Features: n/a