docs: add note about the buffer filter & upgrades#15790
Merged
mattklein123 merged 5 commits intoenvoyproxy:mainfrom Mar 31, 2021
Merged
docs: add note about the buffer filter & upgrades#15790mattklein123 merged 5 commits intoenvoyproxy:mainfrom
mattklein123 merged 5 commits intoenvoyproxy:mainfrom
Conversation
The buffer filter breaks websocket upgrades, so add a note about this. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Member
Author
|
cc: @alyssawilk |
alyssawilk
reviewed
Mar 31, 2021
Contributor
alyssawilk
left a comment
There was a problem hiding this comment.
thanks for clarifying this for the next person who runs into this :-)
| :ref:`filters <envoy_v3_api_field_extensions.filters.network.http_connection_manager.v3.HttpConnectionManager.UpgradeConfig.filters>` | ||
| for the given upgrade type, up to and including only using the router filter to send the HTTP | ||
| data upstream. | ||
| data upstream. Note that the :ref:`Buffer filter <envoy_v3_api_msg_extensions.filters.http.buffer.v3.Buffer>` breaks |
Contributor
There was a problem hiding this comment.
s/the Buffer filter breaks upgrades/buffering is generally not compatible with upgrades/
I think you could arguably have an H2 upgrade that worked with the buffer filter but it would be unusual, not the norm.
added 2 commits
March 31, 2021 12:47
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
alyssawilk
reviewed
Mar 31, 2021
alyssawilk
reviewed
Mar 31, 2021
Contributor
alyssawilk
left a comment
There was a problem hiding this comment.
Nice! LGTM modulo 1.5 remaining nits :-)
added 2 commits
March 31, 2021 12:57
alyssawilk
approved these changes
Mar 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The buffer filter breaks web socket upgrades, so add a note about
this.
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com