grid: enabling parallel connect attempts#15779
Merged
alyssawilk merged 3 commits intoenvoyproxy:mainfrom Apr 5, 2021
Merged
Conversation
f25ae78 to
509cf32
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
509cf32 to
db9ff61
Compare
| EXPECT_NE(grid_.second(), nullptr); | ||
|
|
||
| // onPoolFailure should not be passed up the first time. Instead the grid | ||
| // should wait on the other pool |
| // Test both pools failing | ||
| TEST_F(ConnectivityGridTest, FailureTwice) { | ||
| // Test both connections happening in parallel and both failing. | ||
| TEST_F(ConnectivityGridTest, DoubleFailureParallel) { |
Contributor
There was a problem hiding this comment.
Should we also add a separate DoubleFailureSerial test?
Contributor
Author
There was a problem hiding this comment.
IMO not worth it - the serial code is pretty trivial compared to parallel but I can add in a follow-up if you think it's worth having
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
mattklein123
approved these changes
Apr 4, 2021
Member
mattklein123
left a comment
There was a problem hiding this comment.
Very cool. (Note I'm just skimming since this is a WIP feature and @DavidSchinazi reviewed), let me know if there is anything in particular you want me to look at).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: n/a (not used in prod)
Testing: unit tests
Docs Changes: n/a
Part of #15649