Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
include/envoy/http/conn_pool.h
Outdated
| Callbacks& callbacks) PURE; | ||
|
|
||
| /** | ||
| * Returns a user-friendly protocol descipton for logging. |
Contributor
There was a problem hiding this comment.
Is protocol description the right thing here? if longer term we want to add cell vs Wi-Fi, should that be reflected? If that the case, should this be named description?
Contributor
Author
There was a problem hiding this comment.
My thought is we'd have separate strings for each, and combine in the pool, but we can rename if we end up going the other way.
source/common/http/conn_pool_base.h
Outdated
| random_generator, state, protocol), | ||
| codec_fn_(codec_fn), client_fn_(client_fn) {} | ||
| codec_fn_(codec_fn), client_fn_(client_fn), protocol_(protocol[0]) { | ||
| ASSERT(protocol.size() == 1); |
Contributor
There was a problem hiding this comment.
nit: I'm realizing that this predates this change, but should this parameter be called protocols since it's a vector?
DavidSchinazi
approved these changes
Mar 31, 2021
yanavlasov
approved these changes
Apr 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding trace logs to the connectivity grid
Risk Level: n/a (adding an accessor to connection pools)
Testing: new unit tests
Part of #15649