remove exception to status legacy code from http codec#15773
Merged
mattklein123 merged 5 commits intoenvoyproxy:mainfrom Mar 31, 2021
Merged
remove exception to status legacy code from http codec#15773mattklein123 merged 5 commits intoenvoyproxy:mainfrom
mattklein123 merged 5 commits intoenvoyproxy:mainfrom
Conversation
added 2 commits
March 30, 2021 16:05
Signed-off-by: chaoqin-li1123 <chaoqinli@google.com>
asraa
previously approved these changes
Mar 30, 2021
Contributor
asraa
left a comment
There was a problem hiding this comment.
Awesome! Thank you for the cleanup.
BTW Got worried in case there were random other EnvoyExceptions floating through some helper methods in the dispatch callstack, but just saw they would have been uncaught and we would have seen them.
Thank you!
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
mattklein123
requested changes
Mar 30, 2021
Member
mattklein123
left a comment
There was a problem hiding this comment.
Awesome, thanks. Can we remove innerDispatch() also as I don't think it's needed anymore?
/wait
Contributor
Author
Sure, that sounds reasonable. |
added 3 commits
March 31, 2021 04:35
Signed-off-by: chaoqin-li1123 <chaoqinli@google.com>
Signed-off-by: chaoqin-li1123 <chaoqinli@google.com>
Signed-off-by: chaoqin-li1123 <chaoqinli@google.com>
Contributor
|
Thanks for catching that Matt! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chaoqin-li1123 chaoqinli@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: exceptionToStatus is used in the migration from C++ exception to error status in http codec. since the exception is no longer used, remove the exception and the exceptionToStatus utility function from the codebase. This is also part of the effort to remove exception from data plane. (#14320)
Additional Description:
Risk Level:low
Testing:none
Docs Changes:none
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]