doc: improve build guide doc#15764
Merged
mattklein123 merged 3 commits intoenvoyproxy:mainfrom Mar 31, 2021
Merged
Conversation
Signed-off-by: qinggniq <livewithblank@gmail.com>
Contributor
Author
phlax
requested changes
Mar 30, 2021
bazel/README.md
Outdated
| [clangd](https://clangd.llvm.org/) with supported editors. | ||
|
|
||
| For example, use following command to prepare a compilation database: | ||
| This requires Python 3.8.0+, download from [here](https://www.python.org/downloads/) if you do not have one. Then, use following command to prepare a compilation database: |
Member
There was a problem hiding this comment.
can i suggest the follow modification:
This requires Python 3.8.0+, download from [here](https://www.python.org/downloads/) if you do no have it installed already.
Use following command to prepare a compilation database:
phlax
previously approved these changes
Mar 30, 2021
Member
|
@qinggniq you will need to fix DCO: https://github.com/envoyproxy/envoy/pull/15764/checks?check_run_id=2227156496 |
Signed-off-by: qinggniq <livewithblank@outlook.com>
mattklein123
requested changes
Mar 30, 2021
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks just some small comments.
/wait
bazel/README.md
Outdated
| [clangd](https://clangd.llvm.org/) with supported editors. | ||
|
|
||
| For example, use following command to prepare a compilation database: | ||
| This requires Python 3.8.0+, download from [here](https://www.python.org/downloads/) if you do no have it installed already. |
Member
There was a problem hiding this comment.
Suggested change
| This requires Python 3.8.0+, download from [here](https://www.python.org/downloads/) if you do no have it installed already. | |
| This requires Python 3.8.0+, download from [here](https://www.python.org/downloads/) if you do not have it installed already. |
bazel/README.md
Outdated
| For example, use following command to prepare a compilation database: | ||
| This requires Python 3.8.0+, download from [here](https://www.python.org/downloads/) if you do no have it installed already. | ||
|
|
||
| Use following command to prepare a compilation database: |
Member
There was a problem hiding this comment.
Suggested change
| Use following command to prepare a compilation database: | |
| Use the following command to prepare a compilation database: |
Member
|
apologies for my typos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: qinggniq livewithblank@gmail.com
Due to recent update of python package , now only python version >3.8.0 can use
./tools/vscode/refresh_compdb.sh, we should let developers know.related discussion
https://envoyproxy.slack.com/archives/C78HA81DH/p1617087308144200
Commit Message: improve build guide doc
Additional Description:
Risk Level: Low
Testing: No
Docs Changes: Yes
Release Notes: No
Platform Specific Features: No
[Optional Runtime guard:]
[Optional Fixes #Issue] #15754
[Optional Deprecated:]
[Optional API Considerations:]