Add Windows section in building.rst#15749
Merged
mattklein123 merged 8 commits intoenvoyproxy:mainfrom Apr 1, 2021
Merged
Conversation
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Member
Author
phlax
reviewed
Mar 29, 2021
phlax
reviewed
Mar 29, 2021
phlax
reviewed
Mar 29, 2021
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
phlax
reviewed
Mar 29, 2021
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
moderation
reviewed
Mar 29, 2021
Member
Author
|
@phlax I think you are getting confused because the docs are ambiguous. I will clarify it so it's clear for the next person |
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
phlax
reviewed
Mar 29, 2021
rmiller14
reviewed
Mar 30, 2021
added 2 commits
March 30, 2021 12:00
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Member
|
docs are rendered here https://storage.googleapis.com/envoy-pr/15749/docs/index.html |
wrowe
reviewed
Mar 31, 2021
phlax
reviewed
Apr 1, 2021
docs/root/start/building.rst
Outdated
| Requirements | ||
| ------------ | ||
| Linux/Mac Requirements | ||
| ---------------------- |
Member
There was a problem hiding this comment.
theres still something confusing about this
iiuc this is building for a linux/mac target - but could also be on windows
phlax
reviewed
Apr 1, 2021
phlax
reviewed
Apr 1, 2021
phlax
requested changes
Apr 1, 2021
Member
phlax
left a comment
There was a problem hiding this comment.
@davinci26 looking good - ive left a nit about the changes to the code blocks in the md file
i think there is still something a bit confusing with the titles - not sure of best resolution
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
mattklein123
approved these changes
Apr 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com
Commit Message:
Add Windows section in
building.rst